Change advanced task EnableServiceLinks to be false by default#378
Merged
Merged
Conversation
bomoko
force-pushed
the
chore-disable-enableServiceLinks-on-ad-task
branch
from
e9d4487 to
6aa1d33
Compare
shreddedbacon
approved these changes
May 7, 2026
Member
shreddedbacon
left a comment
shreddedbacon
left a comment
There was a problem hiding this comment.
Great stuff to bring in line with other services.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This disables the default k8s service links from being injected into advanced task pods.
This allows us to make the same kind of assumptions about what environment information is available as we would in, say, a
clipod.