Skip to content

Change advanced task EnableServiceLinks to be false by default #378

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
shreddedbacon merged 1 commit into from
May 7, 2026
Merged

Change advanced task EnableServiceLinks to be false by default #378

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions internal/controllers/v1beta2/task_controller.go
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -609,6 +609,10 @@ func (r *LagoonTaskReconciler) createAdvancedTask(ctx context.Context, lagoonTas
Name: lagoonTask.Name,
}, newPod)
if err != nil {

// For now, we disable service links to bring advanced tasks in line with `cli` pods behavior in terms of env vars
enableServiceLinks := false

newPod := &corev1.Pod{
ObjectMeta: metav1.ObjectMeta{
Name: lagoonTask.Name,
Expand Down Expand Up @@ -641,6 +645,7 @@ func (r *LagoonTaskReconciler) createAdvancedTask(ctx context.Context, lagoonTas
VolumeMounts: volumeMounts,
},
},
EnableServiceLinks: &enableServiceLinks,
},
}
// check if the lagoon-env secret(s) exist and mount them to the pod as required, or fall back to the configmap
Expand Down
Loading