Skip to content

cp: strip setuid/setgid when ownership preservation fails #9777

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Open
Darius-Constantin wants to merge 5 commits into
base: main
Choose a base branch
from
Open

cp: strip setuid/setgid when ownership preservation fails #9777

Darius-Constantin wants to merge 5 commits into from

Conversation

@Darius-Constantin
Copy link

@Darius-Constantin Darius-Constantin commented Dec 22, 2025 •
edited by cakebaker
Loading

Fixes #9750.

Changed handle_preserve to FnMut, such that a flag is set if ownership cannot be preserved, in which case the UID and GID bits are cleared.

@github-actions
Copy link

github-actions bot commented Dec 22, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@sylvestre
Copy link
Contributor

sylvestre commented Dec 22, 2025

A bunch of jobs are failing.
Also could you please add a test to make sure we don't regress in the future? Thanks

Darius-Constantin and others added 3 commits December 22, 2025 18:41
@Darius-Constantin
cp: ensured UID/GID stripping only for unix systems and added test
308ef1f 
Signed-off-by: Darius-Constantin <darius.constantin04@stud.acs.upb.ro>
@Darius-Constantin
Merge branch 'main' into cp-preserve-strip-setuid-on-chown-fail
27c56e6
@Darius-Constantin
Merge branch 'cp-preserve-strip-setuid-on-chown-fail' of github.com:D…
25feb04 
…arius-Constantin/coreutils into cp-preserve-strip-setuid-on-chown-fail
@github-actions
Copy link

github-actions bot commented Dec 22, 2025

GNU testsuite comparison:

Congrats! The gnu test tests/printf/printf-surprise is now passing!
Note: The gnu test tests/dd/no-allocate was skipped on 'main' but is now failing.
Note: The gnu test tests/misc/write-errors was skipped on 'main' but is now failing.

@iburaky2 iburaky2 mentioned this pull request Dec 22, 2025
Open
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

No reviews

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

cp -p doesn't strip setuid/setgid bits when chown fails

2 participants

@Darius-Constantin @sylvestre