Datagen everything that can be#959
Datagen everything that can be#959GizmoTheMoonPig wants to merge 2 commits intovectorwing:dev/1.3from
Conversation
|
Hi! Sorry for delaying my review... things have been rough regarding my drive to work on the mod this past year, and I ended up on a long hiatus again. First off, thanks for making this a datagen-only PR, as per my previous request! The sheer volume of changes intimidated me at first, especially since datagen requires me to learn how each thing works so I can maintain it. I am currently making an effort to zero out all PR's and issues for the 1.3 update, so I can look into this one fully now, if you're still available to update it. If not, that's also fine, and I apologize again for my delay. 🙏 |
|
|
||
| import java.util.function.Supplier; | ||
|
|
||
| public class Language extends LanguageProvider { |
There was a problem hiding this comment.
I think I prefer not datagenning the en_us lang.
Looking at the output, it sorts every lang in alphabetical order, while I prefer sorting them through arbitrary groups to make it more human-readable for translators, especially since we don't have a translation tool such as Crowdin.
Since langs are a very manually-updated thing, it being separate from the others also makes things a bit harder to maintain. I update pt_br and en_pt by hand as well.
Could you please revert the lang datagen?
This is an updated version of my previous PR #796.
Changes in this PR:
entity/signsdirectory for your signs already, vanilla covers this for you.farmersdelight.subtitles.tomato.pick->farmersdelight.subtitles.tomato_bush.pick_tomatoes). I went ahead and updated the key in all the translations the mod has as well.You may notice there's still quite a few files in the data and assets folder that could potentially be moved to datagen. Here's my reasoning for not:
Future things to do:
If anything isn't to your liking, please let me know and I will fix it. Thank you!