Skip to content

fix/update paths to remove local dev errors#625

Open
MCesarczyk wants to merge 5 commits into
visgl:masterfrom
MCesarczyk:fix/update-paths-to-remove-local-dev-errors
Open

fix/update paths to remove local dev errors#625
MCesarczyk wants to merge 5 commits into
visgl:masterfrom
MCesarczyk:fix/update-paths-to-remove-local-dev-errors

Conversation

@MCesarczyk
Copy link
Copy Markdown
Contributor

@MCesarczyk MCesarczyk commented May 1, 2026

Fixes: #624

  • updated stylesheet paths in all examples

  • fixed global React import issue

  • fixed @luma.gl constants file issue

@charlieforward9
Copy link
Copy Markdown
Collaborator

Ive always had issues with stylesheets in this repo - @ibgreen has made comments that make it seem like the existing pattern works for him, so his review here would be valuable.

@charlieforward9
Copy link
Copy Markdown
Collaborator

I did a quick local repro against current master. The PR merges cleanly, and the test-node failure looks like CI comment permissions rather than failing tests. The website-build failure is real though: @deck.gl/widgets/dist/stylesheet.css is not exported by @deck.gl/widgets, while @deck.gl/widgets/stylesheet.css is the public exported CSS path.

Proposition: keep the example imports on the public path:

import '@deck.gl/widgets/stylesheet.css';

and fix the local-dev resolution issue in examples/vite.config.local.mjs with a targeted alias for @deck.gl/widgets/stylesheet.css, similar to the luma constants workaround. That keeps source examples aligned with package exports while still handling the local Vite alias behavior that appears to be causing #624.

The tsconfig JSX runtime change and the luma constants alias may still be valid, but they seem separable from the stylesheet path issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

[Bug] Local dev issues in examples

2 participants