You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Ive always had issues with stylesheets in this repo - @ibgreen has made comments that make it seem like the existing pattern works for him, so his review here would be valuable.
I did a quick local repro against current master. The PR merges cleanly, and the test-node failure looks like CI comment permissions rather than failing tests. The website-build failure is real though: @deck.gl/widgets/dist/stylesheet.css is not exported by @deck.gl/widgets, while @deck.gl/widgets/stylesheet.css is the public exported CSS path.
Proposition: keep the example imports on the public path:
import'@deck.gl/widgets/stylesheet.css';
and fix the local-dev resolution issue in examples/vite.config.local.mjs with a targeted alias for @deck.gl/widgets/stylesheet.css, similar to the luma constants workaround. That keeps source examples aligned with package exports while still handling the local Vite alias behavior that appears to be causing #624.
The tsconfig JSX runtime change and the luma constants alias may still be valid, but they seem separable from the stylesheet path issue.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fixes: #624
updated stylesheet paths in all examples
fixed global React import issue
fixed @luma.gl constants file issue