Skip to content

fix/removeStoreNameTitle#45

Merged
vmourac-vtex merged 8 commits into
masterfrom
fix/removeStoreNameTitle
Aug 13, 2025
Merged

fix/removeStoreNameTitle#45
vmourac-vtex merged 8 commits into
masterfrom
fix/removeStoreNameTitle

Conversation

@caroolcanelas2

Copy link
Copy Markdown
Contributor

Fix the og:title not taking into consideration the removeStoreNameTitle tag from store settings

What problem is this solving?

The og:title was not respecting the removeStoreNameTitle tag from store settings

How to test it?

You can test the fix on this workspace:
https://ccanelas--bellapiel.myvtex.com/isdinceutics-k-ox-eyes-3608/p

Screenshots or example usage:

After
image

How does this PR make you feel? 🔗

Fix the og:title not taking into consideration the removeStoreNameTitle tag from store settings
@caroolcanelas2 caroolcanelas2 requested a review from a team as a code owner June 10, 2025 17:12
@caroolcanelas2 caroolcanelas2 requested review from gabpaladino, leo-prange-vtex and vmourac-vtex and removed request for a team June 10, 2025 17:12
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Jun 10, 2025

Copy link
Copy Markdown
Contributor

Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖

Please select which version do you want to release:

  • Patch (backwards-compatible bug fixes)

  • Minor (backwards-compatible functionality)

  • Major (incompatible API changes)

And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.

  • No thanks, I would rather do it manually 😞

@vtex-io-docs-bot

vtex-io-docs-bot Bot commented Jun 10, 2025

Copy link
Copy Markdown

Beep boop 🤖

I noticed you didn't make any changes at the docs/ folder

  • There's nothing new to document 🤔
  • I'll do it later 😞

In order to keep track, I'll create an issue if you decide now is not a good time

  • I just updated 🎉🎉

@vmourac-vtex vmourac-vtex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@caroolcanelas2 testei aqui e deu certo. Estou só sugerindo uma mudança no código para evitar aninhamento de ifs

No mais, vale corrigir os erros de Lint que foram reportados.

Comment thread react/ProductOpenGraph.tsx Outdated

@vmourac-vtex vmourac-vtex left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM!

@vmourac-vtex vmourac-vtex merged commit 3f95c4a into master Aug 13, 2025
9 checks passed
@vmourac-vtex vmourac-vtex deleted the fix/removeStoreNameTitle branch August 13, 2025 17:27
@vtex-io-ci-cd

vtex-io-ci-cd Bot commented Aug 13, 2025

Copy link
Copy Markdown
Contributor

Your PR has been merged! App is being published. 🚀
Version 1.4.0 → 1.4.1

After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:

vtex deploy vtex.open-graph@1.4.1

After that your app will be updated on all accounts.

For more information on the deployment process check the docs. 📖

@iago1501 iago1501 left a comment

Copy link
Copy Markdown
Contributor

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Nice catch

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

3 participants