fix/removeStoreNameTitle#45
Conversation
Fix the og:title not taking into consideration the removeStoreNameTitle tag from store settings
|
Hi! I'm VTEX IO CI/CD Bot and I'll be helping you to publish your app! 🤖 Please select which version do you want to release:
And then you just need to merge your PR when you are ready! There is no need to create a release commit/tag.
|
|
Beep boop 🤖 I noticed you didn't make any changes at the
In order to keep track, I'll create an issue if you decide now is not a good time
|
vmourac-vtex
left a comment
There was a problem hiding this comment.
@caroolcanelas2 testei aqui e deu certo. Estou só sugerindo uma mudança no código para evitar aninhamento de ifs
No mais, vale corrigir os erros de Lint que foram reportados.
Correcting the 2 ifs in the removeStoreNameTitle
Correcting lint problems
Fix lint errors again
|
Your PR has been merged! App is being published. 🚀 After the publishing process has been completed (check #vtex-io-releases) and doing A/B tests with the new version, you can deploy your release by running:
After that your app will be updated on all accounts. For more information on the deployment process check the docs. 📖 |
Fix the og:title not taking into consideration the removeStoreNameTitle tag from store settings
What problem is this solving?
The og:title was not respecting the removeStoreNameTitle tag from store settings
How to test it?
You can test the fix on this workspace:
https://ccanelas--bellapiel.myvtex.com/isdinceutics-k-ox-eyes-3608/p
Screenshots or example usage:
After

How does this PR make you feel? 🔗