Skip to content

fix/removeStoreNameTitle #45

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
vmourac-vtex merged 8 commits into from
Aug 13, 2025
Merged

fix/removeStoreNameTitle #45

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
8 commits
Select commit Hold shift + click to select a range
3f15c7e
fix/removeStoreNameTitle
caroolcanelas2 Jun 10, 2025
57c605f
Update CHANGELOG.md
caroolcanelas2 Jul 31, 2025
8f9b58e
Update ProductOpenGraph.tsx
caroolcanelas2 Jul 31, 2025
a2aaae2
Update CHANGELOG.md
caroolcanelas2 Jul 31, 2025
162c3d3
Update ProductOpenGraph.tsx
caroolcanelas2 Jul 31, 2025
0e376dd
Update ProductOpenGraph.tsx
caroolcanelas2 Jul 31, 2025
4b7c543
Update ProductOpenGraph.tsx
caroolcanelas2 Jul 31, 2025
0d0d98f
Fix lint errors
caroolcanelas2 Jul 31, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
3 changes: 3 additions & 0 deletions CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -7,6 +7,9 @@ and this project adheres to [Semantic Versioning](http://semver.org/spec/v2.0.0.

## [Unreleased]

### Fixed
- The og:title was not respecting the removeStoreNameTitle tag from store settings.

### Changed

- Update GitHub actions/cache to v4
Expand Down
2 changes: 1 addition & 1 deletion react/ProductOpenGraph.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,7 @@ function ProductOpenGraph() {
try {
const settings = getSettings('vtex.store')

if (settings) {
if (!settings.removeStoreNameTitle) {
const { storeName, titleTag: storeTitleTag } = settings
const suffix =
(storeTitleTag || storeName) && ` - ${storeTitleTag || storeName}`
Expand Down
Loading