[Completions] Bump command-signatures to 50fe37c1 - #14772
[Completions] Bump command-signatures to 50fe37c1#14772warp-agent-staging[bot] wants to merge 2 commits into
Conversation
Ships the just Justfile recipe generator (command-signatures#307) to the client, along with the tcpdump and openssl specs and the bun package.json script completions merged since the previous pin. Co-Authored-By: Warp Agent <agent@warp.dev>
master picked up #14771, which moved the pin to 5e08807 (openssl). That commit is an ancestor of 50fe37c, so this branch's rev supersedes it: resolved both files by taking master and re-applying the newer rev, letting cargo regenerate Cargo.lock. Co-Authored-By: Warp Agent <agent@warp.dev>
The failing Windows test is a pre-existing flake, not caused by this bumpThe one red required check is 1. The same test fails identically on an unrelated PR. That PR touches nothing this one does. 2. The failure is a deadline timeout. The test polls 3. The code path cannot reach this change. 4. Structurally identical PRs pass. Other Also worth noting: the Baseline caveat: there is no I have rerun the failed job. The 5-second deadline looks too tight for the Windows runner and will likely keep flaking for everyone; worth a separate issue against the test rather than anything in this PR. Update: the rerun is green — |
Description
Bumps the
warp-command-signaturesgit pin in the rootCargo.tomlto50fe37c1, and regeneratesCargo.lockwith cargo.The motivating change is command-signatures#307, which adds the Rust
justrecipe generator. Until this pin moves,just <TAB>in a Justfile directory still falls back to filesystem path suggestions in the client.Merged PRs
Relative to the pin currently on
master(5e08807c), this newly brings in:The dependency is pinned by
revin[workspace.dependencies], so moving the rev is the whole change;Cargo.lockwas regenerated by cargo (not hand-edited) and its diff is limited to the twosource =lines forwarp-command-signaturesandwarp-completion-metadata.Note on the conflict with #14771
This branch was opened when
masterpinned4094b657. #14771 then landed and moved the pin to5e08807c(openssl), which conflicted here.5e08807cis a strict ancestor of50fe37c1— two commits back oncommand-signatures:main— so resolving to50fe37c1is a fast-forward that loses nothing from #14771; the openssl (#304) and bun (#301) specs it shipped are already included. Verified withgit merge-base --is-ancestor 5e08807c 50fe37c1, and independently viagh api repos/warpdotdev/command-signatures/compare/50fe37c...5e08807c→status: behind, behind_by: 2, ahead_by: 0.masterwas merged in (not rebased, to preserve the existing approval) and both conflicted files were resolved by takingmaster's copy and re-applying the newer rev, letting cargo regenerate the lock. The net diff against the new base is unchanged in shape: oneCargo.tomlrev line plus the twoCargo.locksource =lines, with no unrelated dependency movement.Linked Issue
Closes #1906
Tracked in APP-5207.
ready-to-implement.Testing
This is a dependency-pin bump — testing-exempt under the "dependency/version bump" category, since a test here could only assert the rev string rather than detect a logic defect. The behavior it ships is already covered by the tests added in command-signatures#307 (9 tests over the recipe generator's post-processing, including private-recipe handling and the graceful no-Justfile / no-
justpaths).Run locally on this branch, and re-run after merging
masterin:cargo fmt --all --check— clean.cargo check -p warp-command-signatures --locked— the new rev resolves and compiles, and--lockedconfirmsCargo.lockis consistent with the manifest.cargo check -p warp_completer --lockedandcargo check -p warp --lib --locked— the consumers of the dependency build against the new rev.cargo clippy -p warp_completer --all-targets --locked -- -D warnings— clean.cargo nextest run -p warp_completer --locked --no-fail-fast— 163 tests: 138 passed, 25 failed, 4 skipped. The 25 failures are pre-existing in this sandbox and unrelated to the bump: they all panic withTried to check FeatureFlag::CloudEnvironments before feature flags were initialized, and running the identical command on pristinemaster(this branch withCargo.toml/Cargo.lockstashed) gives byte-for-byte the same138 passed, 25 failed, 4 skipped. Net delta from this change is zero.The full workspace suite was not run locally; CI is the backstop for it.
./script/runBuilding and running the GUI to TAB-complete a recipe was not possible in this headless environment. The change itself has no rendered surface of its own — it only moves a dependency rev — so there is no UI diff to screenshot beyond the completions menu the merged generator produces.
Agent Mode
CHANGELOG-IMPROVEMENT: Added completions for
justrecipes from your Justfile and fortcpdump.Originating thread: https://warpdev.slack.com/archives/C0BDQDW8V5E/p1785982310270809
Conversation: https://staging.warp.dev/conversation/e450180d-3523-4c00-8d34-59a96e0edf7f
Run: https://oz.staging.warp.dev/runs/019fd4e0-3937-72e5-9624-4be092502e6f
This PR was generated with Oz.