Replace javax servlet classes with Jakarta servlet#224
Replace javax servlet classes with Jakarta servlet#224madoxas wants to merge 1 commit intoweavejester:masterfrom
Conversation
|
Thanks for the PR. This should be okay, as the javax servlets are deprecated in pretty much everything, and Lein-Ring is not 1.0 so there's no guarantee of backward compatibility. That said, if someone complains we can always put an option in to switch from one to the other. Have you tested this change? Does it produce a war file that runs under a servlet container? Also, can you change the commit message to: This will make it consistent with the other commits in the repository. |
Done.
Yes, tested on Tomcat 11. Works as expected. |
|
Thank you for your work on this. Any idea of when this will be released? |
|
I tested this pull request today with a project and it fixed the error I was seeing previously when running Previously bumping from After using the pull request locally, |
Fixes ring-clojure/ring#517
Note: This is a breaking change!
I'm open for suggestions, if there's a need to support both javax and jakarta servlets in the code.