ci: move off retired ubuntu-20.04 runner and pin ruff for generated-code tests#50
Merged
Conversation
GitHub retired the ubuntu-20.04 runner image, so the code-quality and unit-test jobs queued forever and never started. Move them to ubuntu-22.04, which the installation job already uses successfully and which still provides Python 3.7/3.8 via actions/setup-python. Python 3.6 is dropped from the unit-test matrix because no 3.6 builds exist for ubuntu-22.04; 3.7 through 3.13 remain. Pin bqplot<0.13 (0.13 breaks import) and pandas<3 (breaks one test) at the workflow install step rather than in pyproject, since these are CI-environment issues, not package requirements. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
The generate_test.py assertions encode the output of `ruff format`, which changed its blank-line style in newer releases, so an unpinned ruff makes these tests fail in CI. Pin ruff to 0.8.3, the same version the pre-commit hook already uses, where the tests pass. Co-Authored-By: Claude Fable 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
What
Two small CI fixes that currently block the test workflow on every PR:
Retired runner —
code-qualityandunit-testjobs ran onubuntu-20.04, which GitHub retired, so the jobs queued forever and never started. Moved both toubuntu-22.04(which the install job already uses). Python 3.6 is dropped from the unit-test matrix because there is no 3.6 build for ubuntu-22.04; 3.7–3.13 remain.Formatter drift —
reacton/generate_test.pycompares generated source against ruff-formatted expectations. ruff 0.15 changed its style (keeps a blank line at the start of a function body), so the unpinned[dev]install made these tests fail. Pinnedruff==0.8.3at the CI install step, matching the version in.pre-commit-config.yaml.Why separate
This unblocks CI for the whole repo independently of any feature work, so it should land first.
🤖 Generated with Claude Code