Skip to content

fix: handle empty and multi-context results in evalLnot#83

Open
mmsqe wants to merge 6 commits intowill62794:masterfrom
mmsqe:fix_eval
Open

fix: handle empty and multi-context results in evalLnot#83
mmsqe wants to merge 6 commits intowill62794:masterfrom
mmsqe:fix_eval

Conversation

@mmsqe
Copy link
Contributor

@mmsqe mmsqe commented Mar 16, 2026

to avoid handle ~ValidateTx(txn) <-> ValidateTx(txn) = FALSE differently, which are equivalent in TLC.

@will62794
Copy link
Owner

will62794 commented Mar 22, 2026

When making changes to the interpreter like this, I would expect there to be a concrete spec that demonstrates the bug, and that the fix addresses this. Is there such a spec? It's not clear to me from your changes. Same goes for #84.

Also, the convention is to test interpreter changes by adding a test spec in this directory, which then allows for utilization of the framework for conformance checking against TLC (see test list defined here). The Playwright tests are moreso meant for testing of basic UI functionality.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants