fix: handle empty and multi-context results in evalLnot#83
Open
mmsqe wants to merge 6 commits intowill62794:masterfrom
Open
fix: handle empty and multi-context results in evalLnot#83mmsqe wants to merge 6 commits intowill62794:masterfrom
mmsqe wants to merge 6 commits intowill62794:masterfrom
Conversation
Owner
|
When making changes to the interpreter like this, I would expect there to be a concrete spec that demonstrates the bug, and that the fix addresses this. Is there such a spec? It's not clear to me from your changes. Same goes for #84. Also, the convention is to test interpreter changes by adding a test spec in this directory, which then allows for utilization of the framework for conformance checking against TLC (see test list defined here). The Playwright tests are moreso meant for testing of basic UI functionality. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
to avoid handle
~ValidateTx(txn)<->ValidateTx(txn) = FALSEdifferently, which are equivalent in TLC.