fix: failure message for adding user with no mls client (WPB-17105)#4659
Open
sbakhtiarov wants to merge 1 commit intodevelopfrom
Open
fix: failure message for adding user with no mls client (WPB-17105)#4659sbakhtiarov wants to merge 1 commit intodevelopfrom
sbakhtiarov wants to merge 1 commit intodevelopfrom
Conversation
|
saleniuk
reviewed
Mar 17, 2026
| <string name="url_learn_about_search" translatable="false">https://support.wire.com/hc/articles/203121850</string> | ||
| <string name="url_legal_hold_learn_more" translatable="false">https://support.wire.com/hc/articles/360002018278</string> | ||
| <string name="url_message_details_offline_backends_learn_more" translatable="false">https://support.wire.com/hc/articles/9357718008093</string> | ||
| <string name="url_mls_learn_more" translatable="false">https://support.wire.com/hc/en-us/articles/12434725011485-Messaging-Layer-Security-MLS</string> |
Contributor
There was a problem hiding this comment.
I would suggest to remove the locale part, we usually use these urls without it, so that the article will open using the current device's locale. You can also shorten this url, just like all others, to have only id of the article, like so: https://support.wire.com/hc/articles/12434725011485
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
https://wearezeta.atlassian.net/browse/WPB-17105
https://wearezeta.atlassian.net/browse/WPB-17105
What's new in this PR?
Issues
When adding user with no MLS client application is showing Federation error and support page in conversation.
Causes (Optional)
MissingKeyPackages error is always mapped to Federation error.
Solutions
Using new MissingKeyPackages error to show correct system message.