Add RPC integration tests and testnet11 smoke test

[joshpainter]

Summary

• Adds 25 in-process integration tests (crates/sage-rpc/tests/rpc.rs) that exercise the JSON → Axum → Sage → HTTP stack without networking or TLS
• Adds a testnet11 end-to-end smoke test (crates/sage-rpc/tests/smoke_test.sh) with 92 assertions covering DIDs, CATs, NFTs, offers, transfers, coin split/combine, pagination, and read-only queries
• Adds --data-dir flag to sage-cli to support running multiple instances with separate data directories
• Fixes Client::new() → Client::from_dir(&path) so CLI subcommands respect --data-dir
• Exposes make_router() in sage-rpc for integration test access without TLS
• Adds .github/workflows/smoke.yml for manual-dispatch CI against testnet11

Test plan

• cargo test -p sage-rpc — 25 integration tests pass
• ./crates/sage-rpc/tests/smoke_test.sh — 92/92 assertions pass on testnet11
• CI workflow: trigger via GitHub Actions "Run workflow" button

🤖 Generated with Claude Code

[joshpainter]

The smoke-test takes about 10 minutes on testnet. It generates new wallets for Alice and Bob on every run. It will wait for you to fund Alice's wallet to start. 0.001 is fine. It will return any leftover TXCH back to the return address at the end from both wallets. Here's example of full test run:

(base) joshpainter@Mac Sage % ./scripts/smoke_test.sh --return-address txch1mky66sy849ylxlu2u3nerr7q6ngpcars2ufpy2amtqqumj4adnrq3krjsh 2>&1

───────────────────────────────────────────────────────
📦 Setup
───────────────────────────────────────────────────────
  🔹 Using existing release binary: /Users/joshpainter/repos/xch-dev/Sage/target/release/sage
  🔹 Alice data dir: /var/folders/hq/jm3m6v5x2m920c3pvlq_03hm0000gn/T//sage-smoke-alice.UNk8jY
  🔹 Bob data dir:   /var/folders/hq/jm3m6v5x2m920c3pvlq_03hm0000gn/T//sage-smoke-bob.7kngCn
  🔹 Alice log: /var/folders/hq/jm3m6v5x2m920c3pvlq_03hm0000gn/T//sage-smoke-alice.UNk8jY/log/app.log
  🔹 Bob log:   /var/folders/hq/jm3m6v5x2m920c3pvlq_03hm0000gn/T//sage-smoke-bob.7kngCn/log/app.log
  🔹 Config files written
  🔹 Starting Alice's RPC server (port 19257)
  🔹 Starting Bob's RPC server (port 19258)
    ⏳ Waiting for server on port 19257...
  🔹 Server on port 19257 is ready (2s)
    ⏳ Waiting for server on port 19258...
  🔹 Server on port 19258 is ready (0s)
  ✅ Alice calls [get_version] successfully

✅ Both servers running (2s)

───────────────────────────────────────────────────────
🔑 Setting up wallets for Alice and Bob
───────────────────────────────────────────────────────
  🔹 Alice mnemonic: <snip>
  🔹 Bob mnemonic: <snip>
  🔹 Alice fingerprint: <snip>
  🔹 Bob fingerprint: <snip>
  🔹 Alice address: txch1g4hnl5as6tjcufj22vfrd344j53encg3farvkkdmvgcut0f67hsqzwustn
  🔹 Bob address: txch15xy4euerykjdmemzmhtla728e7qqrwm6yuf6wsxd3r2sz5smfhuqzhg200

✅ Wallets created for Alice and Bob (4s)

───────────────────────────────────────────────────────
💰 Funding Alice's wallet
───────────────────────────────────────────────────────
  🔹 Please send testnet11 TXCH to:
  🔹   Alice address: txch1g4hnl5as6tjcufj22vfrd344j53encg3farvkkdmvgcut0f67hsqzwustn
  🔹   Bob address funded by Alice
  🔹 Minimum: 0.000005 TXCH (5000000 mojos).
  🔹 Waiting up to 300s for funds to arrive...
    ⏳ Waiting for Alice to receive TXCH ............. ✅ (65s, 133200000 mojos)

✅ Alice's wallet funded (66s)

───────────────────────────────────────────────────────
✂️  Alice splits her coin into 100 for parallel transactions + pagination
───────────────────────────────────────────────────────
  ✅ Alice calls [split] successfully
    ⏳ Waiting for Alice's split to confirm ........... ✅ (55s)
  🔹 Alice now has 100 coins
  ✅ Alice calls [get_coins] and has ≥100 after split (value: 100)
  ✅ Alice calls [get_coins] page 1 returns 25 coins
  ✅ Alice calls [get_coins] page 2 returns 25 coins
  ✅ Alice calls [get_coins] page 3 returns 25 coins
  ✅ Alice calls [get_coins] page 4 returns ≥1 coin (value: 25)
  ✅ Alice calls [get_coins] and returns unique coins across pages (100 unique)
  ✅ Alice calls [get_coins] beyond-range page returns 0 coins

✅ Alice split into 100 coins, pagination verified (56s)

───────────────────────────────────────────────────────
💸 Alice sends 2M mojos to Bob + Alice creates DID (parallel)
───────────────────────────────────────────────────────
  ✅ Alice calls [send_xch] to send 2M mojos to Bob
  ✅ Alice calls [create_did] successfully
    ⏳ Waiting for Alice's send + DID to confirm ............... ✅ (75s)
    ⏳ Waiting for Bob to receive 2M mojos  ✅ (0s, 2000000 mojos)
  ✅ Alice calls [get_dids] and has ≥1 DID (value: 1)
  🔹 DID_ID: did:chia:1sjx37d7ftmln6c4n5l005t2hu7xsfdxkr7ze6llw6qnyfmja85ysypnqw9

✅ Bob funded, Alice has DID (76s)

───────────────────────────────────────────────────────
🏗️  Bob issues CAT (1M mojos) + Alice mints NFT under her DID (parallel)
───────────────────────────────────────────────────────
  ✅ Bob calls [issue_cat] successfully
  ✅ Alice calls [bulk_mint_nfts] successfully
    ⏳ Waiting for Alice's NFT mint to confirm ....................................... ✅ (195s)
    ⏳ Waiting for Bob's CAT issuance to confirm  ✅ (0s)
  ✅ Bob calls [get_cats] and has ≥1 CAT (value: 1)
  🔹 ASSET_ID: 578fb05143466d49ff61cc62e2c7464e363b25976ccf27b0f977c17824b3c6b8
  ✅ Alice calls [get_nfts] and has ≥1 NFT (value: 1)
  🔹 NFT_ID: nft1y2fcvckgv502ljtm266g7cen7a903v5l7lg92wqtf93vzc88zwvsdxpx7j

✅ Bob has CAT, Alice has NFT (199s)

───────────────────────────────────────────────────────
🤝 Alice accepts Bob's offer of 500k CAT for 50k mojos + Alice transfers NFT to Bob
───────────────────────────────────────────────────────
  ✅ Bob calls [make_offer] (500K CAT for 50K mojos)
  🔹 Offer ID: 327a8c3630b8d9abcc6780809450f29e51d6611cbde44cb9c42af7fcac000a68
  ✅ Alice calls [take_offer] successfully
  ✅ Alice calls [transfer_nfts] to send NFT to Bob
    ⏳ Waiting for Alice's offer + NFT transfer to confirm ................ ✅ (80s)
  ✅ Alice calls [get_cats] and has ≥1 CAT from offer (value: 1)
  ✅ Bob calls [get_cats] and still has CATs (value: 1)
    ⏳ Waiting for Bob received NFT  ✅ (0s)
  ✅ Bob calls [get_nfts] and received NFT from Alice (value: 1)
  🔹 Bob has NFT: nft1y2fcvckgv502ljtm266g7cen7a903v5l7lg92wqtf93vzc88zwvsdxpx7j

✅ Offer settled, Bob has NFT, Alice has CAT (83s)

───────────────────────────────────────────────────────
🔀 Alice transfers DID to Bob, Bob sends 100K CAT to Alice + adds URI to NFT
───────────────────────────────────────────────────────
  ✅ Alice calls [transfer_dids] to send DID to Bob
  ✅ Bob calls [send_cat] to send 100K CAT to Alice
  ✅ Bob calls [add_nft_uri] successfully
    ⏳ Waiting for Alice's DID transfer to confirm .............. ✅ (70s)
    ⏳ Waiting for Bob's send CAT + add URI to confirm  ✅ (0s)
    ⏳ Waiting for Bob received DID  ✅ (0s)
  ✅ Bob calls [get_dids] and received DID from Alice (value: 1)

✅ Bob has DID + URI updated, Alice has CAT (74s)

───────────────────────────────────────────────────────
🔗 Alice combines coins, offers 25K CAT to get NFT back from Bob
───────────────────────────────────────────────────────
  ✅ Alice calls [combine] on 99 coins
  ✅ Alice calls [make_offer] (25K CAT for her NFT back)
  ✅ Bob calls [take_offer] to accept Alice's offer
    ⏳ Waiting for Alice's combine to confirm .................. ✅ (90s)
    ⏳ Waiting for Bob's take_offer (NFT back) to confirm . ✅ (5s)
    ⏳ Waiting for Alice received NFT back  ✅ (0s)
  ✅ Alice calls [get_nfts] and got NFT back from Bob (value: 1)
  🔹 Alice has 1 coins after combine + offer

✅ Alice combined coins and got her NFT back (106s)

───────────────────────────────────────────────────────
📖 Read-only queries (Alice + Bob in parallel)
───────────────────────────────────────────────────────
  ✅ Alice calls [get_keys] and returns ≥1 key
  ✅ Alice calls [get_key] successfully
  ✅ Alice calls [get_secret_key] and returns mnemonic
  ✅ Alice calls [check_address] and validates own address
  ✅ Alice calls [check_address] and rejects invalid address
  ✅ Alice calls [get_derivations] and returns ≥1
  ✅ Alice calls [get_networks] successfully
  ✅ Alice calls [get_network] and shows testnet
  ✅ Alice calls [get_database_stats] successfully
  ✅ Alice calls [get_coins] and returns ≥1 coin
  ✅ Alice calls [get_spendable_coin_count] and returns ≥1
  ✅ Alice calls [get_cats] and returns ≥1
  ✅ Alice calls [get_transactions] and returns ≥1
  ✅ Alice calls [get_transaction] successfully
  ✅ Alice calls [perform_database_maintenance] successfully
  ✅ Alice calls [get_nfts] and returns ≥1 NFT
  ✅ Alice calls [get_nft] and returns specific NFT
  ✅ Alice calls [get_nft_collections] successfully
  ✅ Alice calls [get_nft_collection] successfully
  ✅ Alice calls [get_options] and returns list
  ✅ Bob calls [get_keys] and returns ≥1 key
  ✅ Bob calls [get_key] successfully
  ✅ Bob calls [check_address] and validates own address
  ✅ Bob calls [check_address] and rejects invalid address
  ✅ Bob calls [get_all_cats] and returns ≥1
  ✅ Bob calls [get_token] and returns CAT info
  ✅ Bob calls [get_coins] and returns ≥1 coin
  ✅ Bob calls [get_spendable_coin_count] and returns ≥1
  ✅ Bob calls [get_spendable_coin_count] (CAT) and returns ≥1
  ✅ Bob calls [is_asset_owned] (CAT) and returns true
  ✅ Bob calls [is_asset_owned] (DID) and returns true
  ✅ Bob calls [get_coins_by_ids] and returns coin
  ✅ Bob calls [get_are_coins_spendable] and returns true
  ✅ Bob calls [get_nfts] and returns 0 NFTs
  ✅ Bob calls [get_nft_collections] successfully
  ✅ Bob calls [get_dids] and returns ≥1
  ✅ Bob calls [get_minter_did_ids] successfully
  ✅ Bob calls [get_user_themes] successfully

✅ Read-only queries done (0s)

───────────────────────────────────────────────────────
🔧 Non-blockchain operations (Alice + Bob in parallel)
───────────────────────────────────────────────────────
  ✅ Alice calls [view_offer] and parses offer
  ✅ Alice calls [rename_key] and updates name
  ✅ Alice calls [increase_derivation_index] successfully
  ✅ Alice calls [update_nft] (hide) successfully
  ✅ Alice calls [update_nft] (show) successfully
  ✅ Alice calls [redownload_nft] successfully
  ✅ Bob calls [get_offers] and returns ≥1 offer
  ✅ Bob calls [get_offer] and returns specific offer
  ✅ Bob calls [get_offers_for_asset] successfully
  ✅ Bob calls [set_wallet_emoji] and updates emoji
  ✅ Bob calls [delete_offer] successfully
  ✅ Bob calls [import_offer] and returns offer_id
  ✅ Bob calls [rename_key] and updates name
  ✅ Bob calls [set_discover_peers] (off) successfully
  ✅ Bob calls [set_discover_peers] (on) successfully
  ✅ Bob calls [set_target_peers] (3) successfully
  ✅ Bob calls [set_target_peers] (5) successfully
  ✅ Bob calls [update_cat] successfully
  ✅ Bob calls [update_did] successfully

✅ Non-blockchain operations done (1s)

───────────────────────────────────────────────────────
🔍 Final state check
───────────────────────────────────────────────────────
  ✅ Alice calls [get_transactions] and has ≥1 transaction (value: 226)
  ✅ Bob calls [get_transactions] and has ≥1 transaction (value: 23)
  🔹 Alice peer count: 5
  🔹 Bob peer count: 5
  ✅ Bob calls [logout] successfully
  ✅ Bob calls [login] successfully

✅ Final state check done (3s)

───────────────────────────────────────────────────────
💸 Returning remaining funds to txch1mky66sy849ylxlu2u3nerr7q6ngpcars2ufpy2amtqqumj4adnrq3krjsh
───────────────────────────────────────────────────────
    ⏳ Returning 649899 mojos from Bob (fee: 1)...
    ⏳ Returning 130748888 mojos from Alice (fee: 710)...
    ⏳ Waiting for Bob's return to confirm . ✅ (5s)
    ⏳ Waiting for Alice's return to confirm ......... ✅ (45s)

✅ Funds returned (may take a block to confirm) (50s)


  🔐 Test wallet seed phrases (for manual inspection):
    Alice: <snip>
    Bob: <snip>

  🎉 All smoke tests passed!

════════════════════════════════════════════════════════════
  🏁 Results: 91 passed, 0 failed
════════════════════════════════════════════════════════════
    ⏳ Cleaning up...
./scripts/smoke_test.sh: line 83: 17621 Terminated: 15          "$SAGE_BIN" --data-dir "$DIR_A" rpc start > /dev/null 2>&1
./scripts/smoke_test.sh: line 83: 17622 Terminated: 15          "$SAGE_BIN" --data-dir "$DIR_B" rpc start > /dev/null 2>&1

[Rigidity]

Thanks - I borrowed the architecture for the RPC tests for this PR #746 and will credit you in the release notes for it. I've avoided adding tests that use a real network since it makes CI flakey and slow. I think the Wallet SDK simulator should be sufficient for most things.