Conversation
Collaborator
Author
|
Thanks to #745 for the general design idea |
3 tasks
There was a problem hiding this comment.
Cursor Bugbot has reviewed your changes and found 1 potential issue.
Bugbot Autofix is OFF. To automatically fix reported issues with Cloud Agents, enable Autofix in the Cursor dashboard.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Note
Medium Risk
Moderate risk because it changes core wallet initialization/logging behavior (global tracing setup, test-mode toggles) and extends sync manager commands to accept injected peers, which could affect runtime behavior if misused.
Overview
Adds an in-process RPC test harness for
sage-rpcby exposingmake_router(...), introducing aPeerSimulator-backedtests.rs, and adding the neededdev-dependencies.Refactors RPC TLS setup by extracting
WalletCertVerifierandload_rustls_configinto dedicated modules, and updatesSage::newto accept atestflag that disables file logging, avoids re-initializing the global tracing subscriber, and configures faster sync timeouts for tests.Extends
sage-walletsync control with a newSyncCommand::AddPeerto inject a pre-connected peer/receiver (used by tests), updates CLI/Tauri call sites for the newSage::new(..., test)signature, and includes minor CI (print Prettier version) plus small NFT UI formatting tweaks.Written by Cursor Bugbot for commit c0cc2ae. This will update automatically on new commits. Configure here.