Skip to content

CheckboxButton no longer leaks HoistInputProps into underlying HTML <button>#4449

Merged
amcclain merged 2 commits into
developfrom
bugfix/checkboxbutton-props
Jun 24, 2026
Merged

CheckboxButton no longer leaks HoistInputProps into underlying HTML <button>#4449
amcclain merged 2 commits into
developfrom
bugfix/checkboxbutton-props

Conversation

@cnrudd

@cnrudd cnrudd commented Jun 24, 2026

Copy link
Copy Markdown
Member

I came across this issue when testing an email scheduler whose form has
fieldDefaults: {commitOnChange: true,... and a checkboxButton formField.

Hoist P/R Checklist

Pull request authors: Review and check off the below. Items that do not apply can also be
checked off to indicate they have been considered. If unclear if a step is relevant, please leave
unchecked and note in comments.

  • Caught up with develop branch as of last change.
  • Added CHANGELOG entry, or determined not required.
  • Reviewed for breaking changes: not a breaking change
  • Updated doc comments / prop-types, or determined not required.
  • Reviewed and tested on Mobile: changed on mobile as well.
  • Created Toolbox branch: not required.

If your change is still a WIP, please use the "Create draft pull request" option in the split
button below to indicate it is not ready yet for a final review.

Pull request reviewers: when merging this P/R, please consider using a squash commit to
collapse multiple intermediate commits into a single commit representing the overall feature
change. This helps keep the commit log clean and easy to scan across releases. PRs containing a
single commit should be rebased when possible.

@cnrudd cnrudd requested review from amcclain and lbwexler June 24, 2026 00:05

@amcclain amcclain left a comment

Copy link
Copy Markdown
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks much for fixing.

@amcclain amcclain merged commit 12495b5 into develop Jun 24, 2026
3 checks passed
@amcclain amcclain deleted the bugfix/checkboxbutton-props branch June 24, 2026 23:13
@amcclain amcclain changed the title CheckboxButton no longer leaks HoistInputProps into underlying HTML <button> element. CheckboxButton no longer leaks HoistInputProps into underlying HTML <button> Jun 24, 2026
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants