Skip to content

CheckboxButton no longer leaks HoistInputProps into underlying HTML <button> #4449

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
amcclain merged 2 commits into from
Jun 24, 2026
Merged

CheckboxButton no longer leaks HoistInputProps into underlying HTML <button> #4449

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
4e2c504
`CheckboxButton` no longer leaks `HoistInputProps` into underlying HT…
cnrudd Jun 24, 2026
f13f080
Merge remote-tracking branch 'origin/develop' into bugfix/checkboxbut…
amcclain Jun 24, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion CHANGELOG.md
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,7 +2,6 @@

## 87.0.0-SNAPSHOT - unreleased


### 🎁 New Features

* `CodeInput` / `JsonInput` now auto-format content for display via their configured `formatter`,
Expand All @@ -27,6 +26,7 @@
focused and committed (full-precision) value.
* Fixed inline grid editing not ending when clicking empty grid space to the right of the last
column or below the last row - such clicks now commit the active edit.
* `CheckboxButton` no longer leaks `HoistInputProps` into underlying HTML `<button>` element.

### ⚙️ Typescript API Adjustments

Expand Down
22 changes: 21 additions & 1 deletion desktop/cmp/input/CheckboxButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -47,7 +47,27 @@ class CheckboxButtonInputModel extends HoistInputModel {
// Implementation
//----------------------------------
const cmp = hoistCmp.factory<CheckboxButtonInputModel>(
({model, text, icon, rightIcon, checkedIcon, uncheckedIcon, iconSide, ...props}, ref) => {
(
{
// HoistInput props - exclude from passthrough to BP
bind,
value,
commitOnChange,
onChange,
onCommit,
// Consumed by this component
model,
text,
icon,
rightIcon,
checkedIcon,
uncheckedIcon,
iconSide,
// Remainder passed to hoist button & BP button
...props
},
ref
) => {
const checked = !!model.renderValue,
toggleIcon = checked
? withDefault(checkedIcon, Icon.checkSquare({prefix: 'fas', intent: 'primary'}))
Expand Down
19 changes: 18 additions & 1 deletion mobile/cmp/input/CheckboxButton.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -44,7 +44,24 @@ class CheckboxButtonInputModel extends HoistInputModel {
// Implementation
//----------------------------------
const cmp = hoistCmp.factory<CheckboxButtonInputModel>(
({model, text, checkedIcon, uncheckedIcon, ...props}, ref) => {
(
{
// HoistInput props - exclude from passthrough to Onsen
bind,
value,
commitOnChange,
onChange,
onCommit,
// Consumed by this component
model,
text,
checkedIcon,
uncheckedIcon,
// Remainder passed to hoist button & Onsen button
...props
},
ref
) => {
const checked = !!model.renderValue;
return button({
text: withDefault(text, model.getField()?.displayName),
Expand Down
Loading