fix: use mktemp to prevent /tmp race condition in install.sh#3
Merged
ythx-101 merged 1 commit intoythx-101:masterfrom Mar 14, 2026
Merged
Conversation
Replace hardcoded /tmp/ask-search-wrapper with mktemp to eliminate TOCTOU (time-of-check-time-of-use) symlink attack vector during installation. Co-Authored-By: Claude Opus 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
问题
install.sh 使用固定路径
/tmp/ask-search-wrapper作为临时文件,存在 TOCTOU(time-of-check-time-of-use)竞态条件。攻击者可在写入和 install 之间通过 symlink 替换文件内容,将恶意脚本安装到/usr/local/bin/。修复
将固定
/tmp/ask-search-wrapper替换为mktemp生成的随机临时文件,消除 symlink attack 向量。改动