Issue 2905 password ptorected message compliance #2906
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…essages_error_text' to ClientConfiguration and handle them.| #2905
Collaborator
Author
|
@sosnovsky this one is ready for testing and reviewing |
sosnovsky
reviewed
Dec 10, 2024
...email/ui/gmailapi/passwordprotected/BaseComposeScreenPasswordProtectedDisallowedTermsTest.kt
Show resolved
Hide resolved
sosnovsky
approved these changes
Dec 11, 2024
Collaborator
sosnovsky
left a comment
sosnovsky
left a comment
There was a problem hiding this comment.
Catches all matches now, well done 👍
sosnovsky
deleted the
issue_2905_password-ptorected_message_compliance
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR added changes where we check the subjects of composed password-protected email messages for specified strings
close #2905
Tests (delete all except exactly one):
To be filled by reviewers
I have reviewed that this PR... (tick whichever items you personally focused on during this review):