Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## master #138 +/- ##
==========================================
- Coverage 94.84% 94.62% -0.22%
==========================================
Files 5 5
Lines 446 465 +19
==========================================
+ Hits 423 440 +17
- Misses 23 25 +2 ☔ View full report in Codecov by Sentry. |
|
@MikaelSlevinsky do you know what the grammatrix FastTransforms failure is? |
|
This is closing in but will also need to add an extension to FFTW.jl. @devmotion @jishnub any opinion on whether these extensions should live here/in FFTW.jl or both in ForwardDiff.jl? |
Is this a case issue? 😳 The file clearly exists but with two capital letters. |
|
Every OS apart from MacOS is case-sensitive (I think) |
|
(I probably mean "every file system except AFS and its predecessors HFS and HFS+ but I'm probably a decade out of date 😅) |
|
Yeah it's fixed in 0.16.8 |
Nitpicking: file systems are case-sensitive/insensitive, not operating systems. Also, NTFS, most common file system for Windows, is typically set up to appear case-insensitive to users (even if internally it may behave differently). |
|
I made this PR to drop Julia <v1.10: #140 Maybe we should merge that first and then I can make the suggested changes? |
|
I don't think you have to wait for that PR, you could remove the hard dependency on Julia < 1.9 right away. |
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
…ractFFTs.jl into dl/ForwardDiffExt
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
|
I suspect the complex case can be improved by using Note there is no support for in-place transforms: I don't know how to detect if a plan is in-place. |
This is moving type-piracy code from https://github.com/JuliaApproximation/FastTransformsForwardDiff.jl to an extension here.