Conversation
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## master #140 +/- ##
==========================================
- Coverage 94.83% 94.81% -0.02%
==========================================
Files 4 5 +1
Lines 445 444 -1
==========================================
- Hits 422 421 -1
Misses 23 23 ☔ View full report in Codecov by Sentry. |
| LinearAlgebra = "1" | ||
| Random = "1" | ||
| Test = "1" |
There was a problem hiding this comment.
Are you sure about these changes? A while ago I was told that "<0.0.1, 1" would be needed in some scenarios even on somewhat recent Julia versions. But I don't recall the details.
There was a problem hiding this comment.
There was a problem hiding this comment.
I think it was https://discourse.julialang.org/t/psa-compat-requirements-in-the-general-registry-are-changing/104958#update-november-9th-2023-2 that I had in mind.
There was a problem hiding this comment.
That discussion seems to be relevant only to Julia <v1.10.
There was a problem hiding this comment.
The issue linked in the latest suggestion (of adding <0.0.1) seems to be present in Julia > 1.4 as well: https://discourse.julialang.org/t/why-random-jl-is-fixed-to-version-0-0-0/105957/2
There was a problem hiding this comment.
But do we really want to support this setup when we aren't testing it?
There was a problem hiding this comment.
Also in that discourse someone said:
Right, and the issue is only seen on older versions of Julia
There was a problem hiding this comment.
To my knowledge that's only correct if you do not perform any Pkg operations in your tests.
There was a problem hiding this comment.
But again, we haven't tested such a configuration and so it doesn't make sense to me why we would want to support it
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
The motivation for this change is to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10. In particular, this makes it easier to finish #311 and #318. See also JuliaMath/AbstractFFTs.jl#140 Co-authored-by: Mosè Giordano <765740+giordano@users.noreply.github.com> Co-authored-by: Steven G. Johnson <stevenj@mit.edu> Co-authored-by: David Widmann <devmotion@users.noreply.github.com>
3 participants
The motivation for this change would be to allow adding extensions without adding unnecessary dependencies for users on pre-v1.10.
In particular, this makes it easier to finish #138