Add architecture diagrams and replace ASCII flows with images#3
Add architecture diagrams and replace ASCII flows with images#3mohit-nagaraj merged 1 commit intomainfrom
Conversation
- Add 6 Excalidraw-generated diagrams for data flow and UI architecture - Replace Version Control Flow ASCII block with workflow-versioning.png - Replace Node Data Flow ASCII block with node-data-flow.png - Add workflow-api-flow.png to Workflow Creation section - Add resource-watch-pipeline.png, workflow-status-stream.png, and terminal-exec-session.png under Real-Time Resource Monitoring - Remove default Starlight placeholder docs (guides/example.md, reference/example.md) Signed-off-by: Mohit Nagaraj <mohitnagaraj20@gmail.com>
Summary of ChangesHello @mohit-nagaraj, I'm Gemini Code Assist1! I'm currently reviewing this pull request and will post my feedback shortly. In the meantime, here's a summary to help you and other reviewers quickly get up to speed! This pull request significantly enhances the documentation by integrating new, visually rich architecture diagrams and replacing outdated ASCII art with modern image references. The changes aim to improve the overall readability and understanding of complex system flows, making the documentation more accessible and informative for users and developers alike. Highlights
Changelog
Activity
Using Gemini Code AssistThe full guide for Gemini Code Assist can be found on our documentation page, here are some quick tips. Invoking Gemini You can request assistance from Gemini at any point by creating a comment using either
Customization To customize Gemini Code Assist for GitHub experience, repository maintainers can create a configuration file and/or provide a custom code review style guide (such as PEP-8 for Python) by creating and adding files to a Limitations & Feedback Gemini Code Assist may make mistakes. Please leave feedback on any instances where its feedback is incorrect or counter productive. You can react with 👍 and 👎 on @gemini-code-assist comments. If you're interested in giving your feedback about your experience with Gemini Code Assist for Github and other Google products, sign up here. You can also get AI-powered code generation, chat, as well as code reviews directly in the IDE at no cost with the Gemini Code Assist IDE Extension. Footnotes
|
There was a problem hiding this comment.
Code Review
This pull request improves the documentation by replacing several ASCII art diagrams with clearer, Excalidraw-generated images. It also adds new architecture diagrams to provide more detail on data flows for various features like real-time monitoring. Additionally, it cleans up the project by removing placeholder documentation files. My review focuses on improving the accessibility of the new images by suggesting more descriptive alt text. Overall, these are great changes that enhance the quality of the documentation.
| → Creates new version with old content | ||
| → Updates workflow.nodes and workflow.edges | ||
| ``` | ||
|  |
There was a problem hiding this comment.
For better accessibility, the alt text for this image should be more descriptive. Currently, it just says "Workflow Versioning". A good alt text should briefly describe the image's content for screen readers. This suggestion also applies to the other new images in this file.
For example, the previous ASCII diagram described the flow of saving, comparing, and restoring versions. The alt text could reflect that.
|  | |
|  |
| → React Flow setNodes() | ||
| → Canvas re-renders | ||
| ``` | ||
|  |
There was a problem hiding this comment.
To improve accessibility, the image's alt text should be more descriptive. Instead of just "Node Data Flow", it could summarize the flow it represents. The previous ASCII diagram showed the sequence from a user edit to a canvas re-render.
|  | |
|  |
Summary
data-flow.mdandui-frontend.mdwith proper image referencesguides/example.md,reference/example.md)Test plan
data-flow.mdandui-frontend.md