-
Notifications
You must be signed in to change notification settings - Fork 0
Add architecture diagrams and replace ASCII flows with images #3
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Changes from all commits
File filter
Filter by extension
Conversations
Jump to
Diff view
Diff view
There are no files selected for viewing
| Original file line number | Diff line number | Diff line change | ||||
|---|---|---|---|---|---|---|
|
|
@@ -208,13 +208,7 @@ WorkflowCanvas.tsx | |||||
|
|
||||||
| Each node on the canvas has a `data` property matching a TypeScript interface (defined in `lib/types/nodes.ts`). When a user edits node settings: | ||||||
|
|
||||||
| ``` | ||||||
| User edits in Settings Panel | ||||||
| → WorkflowStore.updateNodeData() | ||||||
| → nodeUpdateHandler callback | ||||||
| → React Flow setNodes() | ||||||
| → Canvas re-renders | ||||||
| ``` | ||||||
|  | ||||||
|
There was a problem hiding this comment. Choose a reason for hiding this commentThe reason will be displayed to describe this comment to others. Learn more. To improve accessibility, the image's alt text should be more descriptive. Instead of just "Node Data Flow", it could summarize the flow it represents. The previous ASCII diagram showed the sequence from a user edit to a canvas re-render.
Suggested change
|
||||||
|
|
||||||
| ### Secret Handling | ||||||
|
|
||||||
|
|
||||||
This file was deleted.
This file was deleted.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
For better accessibility, the alt text for this image should be more descriptive. Currently, it just says "Workflow Versioning". A good alt text should briefly describe the image's content for screen readers. This suggestion also applies to the other new images in this file.
For example, the previous ASCII diagram described the flow of saving, comparing, and restoring versions. The alt text could reflect that.