Merge Upstream to Main#633
Merged
Merged
Conversation
Remove docker compose yaml
Template docker-compose.yaml for merging
Signed-off-by: Paul Gesel <paul.gesel@picknik.ai>
Fix git attributes file
Add src directory
Create .gitignore
Adjust yaml lint to allow for different sequence indent options
It seems like in some version of docker-compose, the services must be
followed by an empty curly bracket `{}` to be valid syntax or
docker-compose will fail with an error message like `services must be a
mapping`.
Make all docker-compose services mappings
`log` wasn't ignored in the build context and was causing cache busts.
Grab important commits
fix: aligning the docker files from example ws
There was a problem hiding this comment.
Pull request overview
This PR aligns the example workspace with upstream maintenance updates for tooling and ignored local build artifacts.
Changes:
- Updates the Hadolint Docker image tag used by pre-commit to match the configured Hadolint revision.
- Adds
.ccache/to ignored local artifacts.
Reviewed changes
Copilot reviewed 1 out of 2 changed files in this pull request and generated no comments.
| File | Description |
|---|---|
.pre-commit-config.yaml |
Updates the Hadolint Docker image entry used by the Dockerfile lint hook. |
.gitignore |
Ignores local ccache output. |
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This should allow
moveit_pro_example_wsto show that it is "up-to-date" withmoveit_pro_empty_ws(I hope).