feat(daemon): adopt Weave Node SDK for tracer provisioning#73
Draft
rgao-coreweave wants to merge 1 commit into
Draft
feat(daemon): adopt Weave Node SDK for tracer provisioning#73rgao-coreweave wants to merge 1 commit into
rgao-coreweave wants to merge 1 commit into
Conversation
Contributor
Author
320f790 to
962da70
Compare
This was referenced Jun 8, 2026
5dcdb1b to
9b884b5
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
First PR in the stack migrating GenAI span emission from hand-rolled OTLP to the Weave Node SDK. Adds the
weavedependency, replacesinitTracer's OTLP exporter +NodeTracerProviderwithweave.init()+getWeaveTracer(), wraps each event handler inweave.runIsolated()for per-event span isolation, and drops theservice.nameresource attribute. The existinggenaiSpanshelpers keep emitting through the Weave provider's tracer; later PRs migrate each span type to the SDK classes.Companion SDK PR: wandb/weave#7262 (re-export
getWeaveTracer).Test plan
npm run buildnpm test