feat(daemon): emit tool spans via weave SDK Tool#76
Draft
rgao-coreweave wants to merge 1 commit into
Draft
Conversation
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 8, 2026
rgao-coreweave
force-pushed
the
migrate-sdk/turn
branch
from
47d0837 to
b61659f
Compare
rgao-coreweave
force-pushed
the
migrate-sdk/tool
branch
from
abd2df8 to
06c08b1
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Migrate tool spans from
startToolSpanto the SDKTool:parent.startTool(...)withtool.result+tool.end(), andtool.setAttributes/addEventfor the display name and permission events. Non-subagent tools parent under the currentTurn.Test plan
npm run buildnpm test