Skip to content

feat(daemon): emit chat spans via weave SDK LLM#78

Draft
rgao-coreweave wants to merge 2 commits into
migrate-sdk/subagentfrom
migrate-sdk/chat
Draft

feat(daemon): emit chat spans via weave SDK LLM#78
rgao-coreweave wants to merge 2 commits into
migrate-sdk/subagentfrom
migrate-sdk/chat

Conversation

@rgao-coreweave

@rgao-coreweave rgao-coreweave commented Jun 8, 2026

Copy link
Copy Markdown
Contributor

Summary

Migrate chat spans from emitChatSpan / emitChatSpansFromAssistantCalls to the SDK LLM via parent.startLLM(...) + llm.record(...), with post-hoc startTime/endTime so replayed spans match transcript timestamps.

Folds in the migration cleanup (per the stack plan, no separate cleanup PR): drops the now-unused genaiSpans span helpers, leaving genaiSpans.ts as a thin ATTR + formatting layer; removes the transitional migration-snapshot test and the helper-level unit tests whose coverage now lives in the SDK genai tests + genai-span-usage-tokens.

Companion SDK PRs: wandb/weave#7078 (post-hoc timing, merged), wandb/weave#7195 (setAttributes/addEvent, merged), wandb/weave#7077 (SubAgent.startLLM).

Test plan

  • npm run build
  • npm test (44 tests)

rgao-coreweave commented Jun 8, 2026

Copy link
Copy Markdown
Contributor Author

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant