feat(daemon): emit chat spans via weave SDK LLM#78
Draft
rgao-coreweave wants to merge 2 commits into
Draft
Conversation
This was referenced Jun 8, 2026
Contributor
Author
|
Warning This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
This stack of pull requests is managed by Graphite. Learn more about stacking. |
This was referenced Jun 8, 2026
13b4dc3 to
b258469
Compare
b69bce9 to
b8d5827
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.

Summary
Migrate chat spans from
emitChatSpan/emitChatSpansFromAssistantCallsto the SDKLLMviaparent.startLLM(...)+llm.record(...), with post-hocstartTime/endTimeso replayed spans match transcript timestamps.Folds in the migration cleanup (per the stack plan, no separate cleanup PR): drops the now-unused
genaiSpansspan helpers, leavinggenaiSpans.tsas a thinATTR+ formatting layer; removes the transitionalmigration-snapshottest and the helper-level unit tests whose coverage now lives in the SDK genai tests +genai-span-usage-tokens.Companion SDK PRs: wandb/weave#7078 (post-hoc timing, merged), wandb/weave#7195 (setAttributes/addEvent, merged), wandb/weave#7077 (SubAgent.startLLM).
Test plan
npm run buildnpm test(44 tests)