fix evalLand empty-branch guard and propagate INSTANCE substitutions in evalUserBoundOp#84
Open
mmsqe wants to merge 13 commits intowill62794:masterfrom
Open
fix evalLand empty-branch guard and propagate INSTANCE substitutions in evalUserBoundOp#84mmsqe wants to merge 13 commits intowill62794:masterfrom
mmsqe wants to merge 13 commits intowill62794:masterfrom
Conversation
mmsqe
added a commit
to mmsqe/blockstm-spec
that referenced
this pull request
Mar 18, 2026
no need after fix in will62794/spectacle#84
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
evalLandassumed both LHS and RHS always produce non-empty boolean results. When a branch returned[], it could access invalid values and throw instead of returning no branch.evalUserBoundOpdid not always carryINSTANCE ... WITHsubstitutions into evaluation of imported operator definitions, substituted identifiers could be resolved in wrong context and lookup fails.