Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0)#394
Open
ChrisonSimtian wants to merge 2 commits into
Open
Introduce IFalloutCommand dispatch with DI for Fallout.Cli (#392, PR 0)#394ChrisonSimtian wants to merge 2 commits into
ChrisonSimtian wants to merge 2 commits into
Conversation
Replace the reflection-over-Program command dispatch (the partial god-class described in #392) with a typed command abstraction resolved through Microsoft.Extensions.DependencyInjection. This is the foundation PR: it lands the abstraction, the dispatcher, the prompt service, and the first real command conversion, with the remaining handlers converted one per follow-up PR. - Add public IFalloutCommand (Name + Execute) and a CommandDispatcher that resolves by name, dash- and case-insensitively, preserving every spelling the old reflection accepted (:add-package == :addpackage, :PopDirectory, ...). - Move the Spectre prompt/render helpers off Program into an injectable IConsolePrompts / SpectreConsolePrompts (namespace Fallout.Cli.Prompts to avoid colliding with System.Console). Program keeps thin static delegators so the not-yet-extracted handlers compile; the last conversion deletes them. - Convert Run into a real RunCommand type; delete Program.Run.cs. - Adapt the 13 still-legacy handlers via a transitional DelegateCommand so the registry and dispatch are uniform from day one. Each future PR deletes one registration line plus its Program.X.cs partial. - Delete the reflection dispatch and its "add assertions about return type and parameters" TODO; typed commands make signature-mismatch dispatch impossible. - Add CommandDispatcherTests (first-ever dispatch coverage): name matching, dash/case insensitivity, exit-code passthrough, unknown-command listing, empty token, and all default-routing branches. - Add .vscode launch/build tasks for debugging the global tool from source. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
ChrisonSimtian
added
the
target/2026
Bump the cross-command helpers (GetConfiguration(buildScript, evaluate), AddOrReplacePackage, WriteBuildScripts, WriteConfigurationFile, GetTemplate, PrintInfo, CurrentBuildScriptName, BUILD_PROJECT_FILE) from private to internal so the per-command IFalloutCommand types extracted in the #392 follow-up PRs can call them during the transition. These move into dedicated services in the final collapse PR; this is the minimal enabler that lets each command be converted in an independent, conflict-free PR. Co-Authored-By: Claude Opus 4.8 (1M context) <noreply@anthropic.com>
This was referenced Jun 17, 2026
Contributor
There was a problem hiding this comment.
Pull request overview
This PR refactors Fallout.Cli command dispatch from reflection over Program methods to a typed IFalloutCommand model routed through a CommandDispatcher, with command instances resolved via Microsoft.Extensions.DependencyInjection. It introduces an injectable prompts abstraction and converts :run to the new command type while adapting the remaining legacy handlers via a DelegateCommand bridge.
Changes:
- Introduces
IFalloutCommand,CommandDispatcher, and a transitionalDelegateCommandadapter; updatesProgram.Mainto dispatch via a DI container. - Extracts console prompting/rendering into
IConsolePrompts+SpectreConsolePrompts, keeping temporaryProgramforwarders for legacy handlers. - Adds initial unit tests for dispatch behavior and wires DI into
Fallout.Clipackage references (central version inDirectory.Packages.props).
Reviewed changes
Copilot reviewed 15 out of 15 changed files in this pull request and generated 4 comments.
Show a summary per file
| File | Description |
|---|---|
| tests/Fallout.Cli.Tests/CommandDispatcherTests.cs | Adds unit coverage for dispatcher matching/forwarding, default routing, and error output. |
| src/Fallout.Cli/Prompts/SpectreConsolePrompts.cs | New Spectre-based implementation of interactive prompts. |
| src/Fallout.Cli/Prompts/IConsolePrompts.cs | New abstraction for prompt/console interactions to support DI/testing. |
| src/Fallout.Cli/Program.Setup.cs | Promotes helper methods to internal for reuse during incremental command extraction. |
| src/Fallout.Cli/Program.GetConfiguration.cs | Promotes shared constants/helpers to internal for reuse during extraction. |
| src/Fallout.Cli/Program.cs | Replaces reflection dispatch with DI-built dispatcher and registers commands/adapters. |
| src/Fallout.Cli/Program.AddPackage.cs | Promotes helper to internal to support incremental refactor. |
| src/Fallout.Cli/Fallout.Cli.csproj | Adds DI package reference (centrally versioned). |
| src/Fallout.Cli/Commands/RunCommand.cs | Converts :run into a standalone IFalloutCommand implementation. |
| src/Fallout.Cli/Commands/IFalloutCommand.cs | Introduces the command contract used for typed dispatch. |
| src/Fallout.Cli/Commands/DelegateCommand.cs | Adds transitional adapter for legacy Program.X handlers. |
| src/Fallout.Cli/CommandDispatcher.cs | Implements dash/case-insensitive routing and default behavior (setup/run). |
| Directory.Packages.props | Adds central package version for Microsoft.Extensions.DependencyInjection. |
| .vscode/tasks.json | Adds VS Code build task for the CLI project. |
| .vscode/launch.json | Adds VS Code launch configurations for common CLI debug flows. |
Comments suppressed due to low confidence (1)
src/Fallout.Cli/Commands/RunCommand.cs:17
RunCommandis declaredpublic, but command types appear to be an internal implementation detail of the CLI tool (and the interface is intended to be internal-by-convention). Making the command typeinternalkeeps the assembly’s public API smaller while still working with DI and tests.
💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.
| /// when a public command SDK lands (milestone #7) the API will be annotated and versioned | ||
| /// explicitly. Until then, treat additions here as internal-by-convention. | ||
| /// </remarks> | ||
| public interface IFalloutCommand |
Comment on lines
+18
to
+20
| /// The canonical command name as typed after the <c>:</c> prefix, in dash form | ||
| /// (e.g. <c>"run"</c>, <c>"add-package"</c>, <c>"cake-convert"</c>). Matched case-insensitively. | ||
| /// </summary> |
| /// <c>static</c> Spectre helpers on <c>Program</c>. The default implementation is | ||
| /// <see cref="SpectreConsolePrompts"/>. | ||
| /// </summary> | ||
| public interface IConsolePrompts |
| /// <see cref="IConsolePrompts"/> backed by <see cref="AnsiConsole"/>. This is the single home for | ||
| /// the interactive prompt logic that previously lived as <c>static</c> helpers on <c>Program</c>. | ||
| /// </summary> | ||
| public sealed class SpectreConsolePrompts : IConsolePrompts |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Replaces the reflection-over-
ProgramCLI dispatch with one-command-per-type behind a typedIFalloutCommand, resolved via Microsoft.Extensions.DependencyInjection. PR 0 of an incremental series — lands the abstraction, dispatcher, and first conversion; a transitional adapter keeps the other 13 handlers working so nothing regresses.What changed
IFalloutCommand+CommandDispatcherreplaceProgram.Handle; resolution stays dash/case-insensitive (every spelling the old reflection accepted).IConsolePrompts/SpectreConsolePrompts— Spectre prompt helpers lifted offPrograminto an injectable service.RunCommand— first real conversion.DelegateCommandadapts the 13 still-legacy handlers so dispatch is uniform; each follow-up PR deletes one.CommandDispatcherTestsadd first dispatch coverage.Why it's not breaking
Fallout.Cliis the tool Exe, not a consumed library; the:commandsurface and shell-function names are preserved exactly. Hencetarget/2026/main, nobreaking-changelabel.Verification
dotnet build src/Fallout.Cliclean ·Fallout.Cli.Tests30 pass ·fallout :bogusprints the full command manifest.Follow-ups (#392): setup · update · add-package · cake-convert/clean · complete · get-configuration · secrets · trigger · navigation → then collapse
Programto a thin entry point.Part of #392.
🤖 Generated with Claude Code